Make link-package's build-deps-for script check transitive deps #6712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make build-deps-for check for Bazel dependencies transitively instead of just on the packages passed to it. Additionally, change the behavior of `build-deps-for` so that when it is passed a Bazel package, it will directly build the package instead of building just its dependencies.
lina128
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
I think the original reason we resolve transitive dependency ourselves is because of circular dependency of cpu and core. If this is not longer the case, then the refactor is the right way to go. Thank you Matt!
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @Linchenn)
mattsoulanille
commented
Aug 3, 2022
There was a problem hiding this comment.
Thanks for the review! Like you said, we no longer have circular devDependencies, but the solution here should still work if we somehow add one. It can only ever visit each package once, so it should not get stuck in a loop (see the visited set in findTransitiveBazelDeps).
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make build-deps-for check for Bazel dependencies transitively instead of just on the packages passed to it. Additionally, change the behavior of
build-deps-forso that when it is passed a Bazel package, it will directly build the package instead of building just its dependencies.To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is