webgpu: export webgpu utilities #6707
Conversation
|
@haoyunfeix Please help to review it, thank you. |
| } | ||
| const device: GPUDevice = await adapter.requestDevice(deviceDescriptor); | ||
| return new WebGPUBackend(device); | ||
| }, 3 /*priority*/); | ||
| } | ||
|
|
||
| export {webgpu}; | ||
| export * from './base'; |
There was a problem hiding this comment.
why not directly call export * from './webgpu'; here?
There was a problem hiding this comment.
Refer it to webgl backend, we could put all wanted export utilities in base.ts file in future.
There was a problem hiding this comment.
The webgl backend puts kernels into the register_all_kernels.ts file and everything else into base.ts. This is for better readability, and makes sure any side effects from setting up the backend happen before kernels are registered (I'm not 100% sure this is necessary). If you want to do the same for webgpu, you could move everything from index.ts into base.ts. However, it's a style choice, and if you prefer to keep everything in index.ts, I think that's fine.
tfjs-backend-webgpu/src/base.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2020 Google Inc. All Rights Reserved. | |||
tfjs-backend-webgpu/src/index.ts
Outdated
| @@ -49,11 +49,12 @@ if (isWebGPUSupported()) { | |||
| }; | |||
|
|
|||
| if (supportTimeQuery) { | |||
| deviceDescriptor.requiredFeatures = ['timestamp-query' as const]; | |||
| deviceDescriptor.requiredFeatures = ['timestamp-query' as const ]; | |||
There was a problem hiding this comment.
I had noticed this extra space, it was added automatically by vs editor.
xhcao
force-pushed
the
exportwebgputs
branch
3 times, most recently
from
ff23db2
to
c28e129
Compare
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is