Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browserstack-benchmark tool #6703

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Fix browserstack-benchmark tool #6703

merged 2 commits into from
Aug 2, 2022

Conversation

Linchenn
Copy link
Collaborator

@Linchenn Linchenn commented Aug 1, 2022 •
edited by nsthorat
Loading

This PR:

  1. Removes local build for tfjs-vis, since this benchmark tool typically does not need it.
  2. Removes unused model parameter from predictFunction function.
  3. Add typeof isTflite === 'function' check before evaluation, because currently bs-benchmark tool does not support tflite.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

This change is Reviewable

mattsoulanille
mattsoulanille approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

jinjingforever
jinjingforever approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@jinjingforever jinjingforever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Linchenn Linchenn merged commit bb62057 into tensorflow:master Aug 2, 2022
@Linchenn Linchenn deleted the fixBs branch August 2, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinjingforever jinjingforever jinjingforever approved these changes

@mattsoulanille mattsoulanille mattsoulanille approved these changes

@lina128 lina128 Awaiting requested review from lina128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linchenn @mattsoulanille @jinjingforever