Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgpu] Fix alignment missing for 5D and 6D #6701

Merged
merged 5 commits into from
Aug 2, 2022

Conversation

haoyunfeix
Copy link
Contributor

@haoyunfeix haoyunfeix commented Aug 1, 2022

BUG
Fixes #6699
Use regExp to match and insert alignment to uniform declaration.

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

BUG
Fixes tensorflow#6699
Use regExp to match and insert alignment to uniform declaration.
@haoyunfeix
Copy link
Contributor Author

@qjia7 @xhcao @axinging @gyagp PTAL

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@qjia7 qjia7 requested a review from gyagp August 2, 2022 01:52
Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

use capturing group to return matched string, which also supports on safari
@haoyunfeix
Copy link
Contributor Author

Use capture groups instead of lookbehind assertions in RegExp to satisfy Safari's compatibility.

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the continuous efforts on this. LGTM.

@qjia7 qjia7 merged commit 52c8844 into tensorflow:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPU fails where WebGL does not
3 participants