-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webgpu] Fix alignment missing for 5D and 6D #6701
Conversation
BUG Fixes tensorflow#6699 Use regExp to match and insert alignment to uniform declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
adddb91
to
721978f
Compare
33559b6
to
653361d
Compare
use capturing group to return matched string, which also supports on safari
Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the continuous efforts on this. LGTM.
BUG
Fixes #6699
Use regExp to match and insert alignment to uniform declaration.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is