[webgpu] Remove extra device stuff passing to the constructor #6689
Conversation
|
@qjia7 PTAL |
| @@ -155,6 +155,14 @@ export class WebGPUBackend extends KernelBackend { | |||
| type: 'timestamp', | |||
| count: 2, | |||
| }); | |||
| } else { | |||
| console.warn( | |||
| `This device doesn't support timestamp-query extension. ` + | |||
There was a problem hiding this comment.
nit: remove the intermediate +. Only one pair of `` is enough.
There was a problem hiding this comment.
Only one pair of `` will separate long warnings to several lines and keep extra spaces at the beginning of each line. 
Below is what is looks like now (in one line):
There was a problem hiding this comment.
I think you can adjust your output layout.
For example:
console.warn(`
This device doesn't support timestamp-query extension.
Start Chrome browser with flag
--disable-dawn-features=disallow_unsafe_apis then try again.
Or zero will shown for the kernel time when profiling mode is
enabled. Using performance.now is not workable for webgpu since
it doesn't support synchronously to read data from GPU.`);
There was a problem hiding this comment.
I thought this also break one sentence into 6 lines, sometimes may cause the typography issue.
For example when console window is less than 70 width(debugging in a small corner), 6 lines will became 6 paragraphs(12+ lines), instead 1 line message will stay in 1 paragraph, easy to read.
| `--disable-dawn-features=disallow_unsafe_apis then try again. ` + | ||
| `Or zero will shown for the kernel time when profiling mode is` + | ||
| `enabled. Using performance.now is not workable for webgpu since` + | ||
| `it doesn't support synchronously to read data from GPU.`); |
There was a problem hiding this comment.
I don't quite understand why we always need this warning. This is a development only extension.
There was a problem hiding this comment.
Just noticed a bug #6691 related with it. Agree with Yang's opinion. We should only print this warning when the users really use it.
BUG While passing both device and device feature to the constructor, there is a potential mismatch between them and cause error, so only keep unique device in backend constructor's parameter.
haoyunfeix
force-pushed
the
webgpu_constructor_update
branch
from
be6c3ab
to
be0af01
Compare
BUG
While passing both device and device feature to the constructor,
there is a potential mismatch between them and cause error, so only keep
unique device in backend constructor's parameter.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is