webgpu: fix notEqual error #6669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add some test cases to cover this? |
qjia7
reviewed
Jul 25, 2022
| @@ -109,8 +109,31 @@ const INT_DIV_VEC4 = ` | |||
| return vec4<f32>(resultTemp); | |||
| `; | |||
|
|
|||
| const NOT_EQUAL = 'return f32(a != b);'; | |||
| const NOT_EQUAL_VEC4 = 'return vec4<f32>(a != b);'; | |||
| const NOT_EQUAL = ` | |||
There was a problem hiding this comment.
It seems that webgl also doesn't check isnan. Can you verify whether webgl has the similar issue on Linux?
There was a problem hiding this comment.
There is no the same issue on the webgl backend. I think the underlying driver or the bin of shader are not the same for these two backends. There are also some situations that webgl check isnan, but webgpu does not check.
gyagp
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is