Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webgpu: dont use mod as it is a reserved keyword #6667

Merged
merged 1 commit into from
Jul 25, 2022
Merged

webgpu: dont use mod as it is a reserved keyword #6667

merged 1 commit into from
Jul 25, 2022

Conversation

crowlKats
Copy link
Contributor

@crowlKats crowlKats commented Jul 23, 2022 •
edited by nsthorat
Loading

as per https://gpuweb.github.io/gpuweb/wgsl/#reserved-words, mod is a reserved keyword, which is causing the webgpu implementation of deno to error. seems chrome doesnt check for these keywords yet.

This change is Reviewable

qjia7
qjia7 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@qjia7 qjia7 requested a review from gyagp July 25, 2022 01:14
gyagp
gyagp approved these changes Jul 25, 2022
View reviewed changes
Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyagp gyagp merged commit c5cf6f5 into tensorflow:master Jul 25, 2022
@crowlKats crowlKats deleted the mod_to_modulo branch July 25, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyagp gyagp gyagp approved these changes

@qjia7 qjia7 qjia7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowlKats @gyagp @qjia7