Set willReadFrequently to true for GPU correctness test #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If willReadFrequently is set to true, 2D canvas will always be backed by CPU. Otherwise, it will be backed by GPU in first call, and backed by CPU in the rest calls. For CPU backends, including CPU and WASM, we set this to true for perfomance. So to compare the results of GPU with CPU, we need to ensure it's always backed by CPU. BUG: tensorflow#6664
|
@axinging PTAL |
lina128
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Thank you for the fix and detailed PR description!
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @mattsoulanille and @pyu10055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If willReadFrequently is set to true, 2D canvas will always be backed by
CPU. Otherwise, it will be backed by GPU in first call, and backed by
CPU in the rest calls.
For CPU backends, including CPU and WASM, we set this to true for
perfomance. So to compare the results of GPU with CPU, we need to ensure
it's always backed by CPU.
BUG: #6664
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is