Run Verdaccio tests in nightly #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyu10055
reviewed
Jul 21, 2022
There was a problem hiding this comment.
This is awesome, do you have a log for this run?
Reviewable status: 0 of 1 approvals obtained
|
The run is failing due to rules_nodejs linker issues. I'm investigating the cause of it, so I converted this PR to a draft until I've fixed the linker issues. |
mattsoulanille
force-pushed
the
verdaccio_in_nightly
branch
from
279e4b3
to
959d8e9
Compare
mattsoulanille
force-pushed
the
verdaccio_in_nightly
branch
from
959d8e9
to
3f2d239
Compare
mattsoulanille
force-pushed
the
verdaccio_in_nightly
branch
from
e5c5ed9
to
76fe952
Compare
mattsoulanille
force-pushed
the
verdaccio_in_nightly
branch
from
9e07be9
to
8a72052
Compare
|
Here's a log of nightly tests running on this branch, including the nightly verdaccio tests. It looks like it will probably pass. Edit: It timed out at the last step. |
pyu10055
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Reviewed 4 of 7 files at r1, 9 of 9 files at r2, 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
jinjingforever
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run Verdaccio tests only when we do a release. Since they're only tested after choosing a release commit from nightly CI, they are often a point of failure. This PR makes them run during nightly tests, so we can identify issues with them before creating a release PR.
This PR also enables Bazel sandboxing, which fixes the rules_nodejs linker issue.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is