Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jasmine] Add expectation to tests in jasmine test framework #6656

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

haoyunfeix
Copy link
Contributor

@haoyunfeix haoyunfeix commented Jul 21, 2022

Fixes #6655

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM.

tfjs-core/src/browser_util_test.ts Outdated Show resolved Hide resolved
@mattsoulanille
Copy link
Member

Hmm. Looks like the GitHub suggestion I made used my personal account, which hasn't signed the CLA, instead of my work account. Let me go sign it.

@gyagp gyagp merged commit 679c545 into tensorflow:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jasmine warning: Spec 'XXX' has no expectations
3 participants