Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webgpu: fix uniform block incorrectly #5487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

webgpu: fix uniform block incorrectly #5487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tfjs-backend-webgpu/src/backend_webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,14 @@ export class WebGPUBackend extends KernelBackend {
currentOffset += d.data.length + padding;
});

// Force the resulting size of uniform block to be evenly divisible
// by sizeof(four-component vector).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add more comments here, so that we can understand why we need those lines, including the related platform and test case. And We'd better provide a test case.

padding = Math.ceil(currentOffset / 4) * 4 - currentOffset;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can 4 be replaced with baseAlignment?

for (let p = 0; p < padding; ++p) {
dimUniformsData.push({type: 'int32', data: [0]});
dataViewIndex++;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need dataViewIndex++;?

}

return this.arrayToDataView(dimUniformsData, dataViewIndex);
}

Expand Down