Fix clamp bug when min = max (#6825)

Co-authored-by: Ping Yu <[email protected]>
tensorflow · Sep 12, 2022 · f8165e2 · f8165e2
1 parent 0b40a7d
commit f8165e2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/tfjs-core/src/ops/clip_by_value.ts b/tfjs-core/src/ops/clip_by_value.ts
@@ -22,6 +22,7 @@ import {NamedTensorMap} from '../tensor_types';
 import {convertToTensor} from '../tensor_util_env';
 import {TensorLike} from '../types';
 import * as util from '../util';
+import {fill} from './fill';
 
 import {op} from './operation';
 
@@ -47,6 +48,10 @@ function clipByValue_<T extends Tensor>(
       () => `Error in clip: min (${clipValueMin}) must be ` +
           `less than or equal to max (${clipValueMax}).`);
 
+  if (clipValueMin === clipValueMax) {
+    return fill($x.shape, clipValueMin, $x.dtype) as T;
+  }
+
   const inputs: ClipByValueInputs = {x: $x};
   const attrs: ClipByValueAttrs = {clipValueMin, clipValueMax};
 

diff --git a/tfjs-core/src/ops/clip_by_value_test.ts b/tfjs-core/src/ops/clip_by_value_test.ts
@@ -141,6 +141,14 @@ describeWithFlags('clipByValue', ALL_ENVS, () => {
     expect(res[1]).toBeCloseTo(max);
   });
 
+  it('clip min = max', async () => {
+    const min = 2;
+    const max = 2;
+    const tensor = tf.tensor([1, 2, 3, 4, 5], [5], 'float32');
+    const result = tf.clipByValue(tensor, min, max);
+    expectArraysClose(await result.data(), [2, 2, 2, 2, 2]);
+  });
+
   it('throws for string tensor', () => {
     expect(() => tf.clipByValue('q', 0, 1))
         .toThrowError(/Argument 'x' passed to 'clipByValue' must be numeric/);