-
Notifications
You must be signed in to change notification settings - Fork 74.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vscode devcontainer #51439
Vscode devcontainer #51439
Conversation
Keras has already merged its own keras-team/keras@4c9cf43 |
I don't know if Tensorflow team members have this setting enabled, if not it will be hard to test this in Codespaces for them (but It is still ok for Vsocde with remote extension): |
/cc @yarri-oss |
Just a small reminder. Of course it will be still free to test on our your HW resources with Vscode desktop and the remote extension. |
@angerson @mihaimaruseac I have minimized he Dockerfile and started to use your new This new setup is oriented to a Docker rootless installation. See |
// Use 'postCreateCommand' to run commands after the container is created. | ||
// "postCreateCommand": "uname -a", | ||
"mounts": [ | ||
"source=tensorflow_cache,target=/root/.cache/bazel/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chuxel Do you know why also using this the bazel
cache is invalidated on every VSCode restart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've debugged a little more and it is seem to related code insider
(daily) update restart. Let me know if you want an upstream ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chuxel I've an upstream ticket now at microsoft/vscode-dev-containers#1453
@mihaimaruseac @angerson @yarri-oss You can test this clicking on the code button |
Note: with the Codespace "free tier" available disk space (individual account) you will have a |
Hi folks 👋! I wanted to provide some updates on development containers that might make this PR more interesting (cc @angerson as part of the initial PR thread). Our team is working on an open dev container specification, so that any user in any tool can create and connect to dev containers. This includes tools beyond VS Code or Codespaces. We recently released the reference implementation as an open source CLI, in addition to an initial version of the spec. We now have a We also introduced a The CLI and spec are both in active development, so they'll continue to evolve, especially with external feedback. We'd love to hear if the spec helps make this PR more viable to become part of TensorFlow, and if there is any feedback or questions that'd make this a better fit - we're more than happy to discuss and collaborate. Thanks! |
Thank you @bamurtaugh for your team updates I hope that @learning-to-play and @angerson could re-evaluate this. In the meantime, on my side, one of the major blockers on this is the upstream issue we have at microsoft/vscode-remote-release#6746. |
@learning-to-play, @angerson, @bhack Any update on this PR? Please. Thank you! |
@theadactyl Can we try to reply to @bamurtaugh?She is a Vscode PM at Microsoft Thanks |
@bamurtaugh Any new on Vscode side for microsoft/vscode-remote-release#6746? |
Thanks for the ping @bhack! Our team has been actively focused on specification work and an updated plan for community contributions and the vscode-dev-containers repo moving forward, which we've now outlined in this issue: microsoft/vscode-dev-containers#1589. This includes moving to a couple new repos for images and Features (https://github.com/devcontainers/images, https://github.com/devcontainers/features), and we anticipate to have a similar repo and process for templates/definitions. Please let me know if you have any questions, thank you! |
@bamurtaugh For TF we need to find a solution for the VSCode ticket at microsoft/vscode-remote-release#6746 Do you have any update? |
Apologies for a potential lack of clarity in my original comment. I meant to explain that our team's primary work has been on the dev container spec and the items I highlighted. microsoft/vscode-remote-release#6746 is on the backlog, but spec work has been at the forefront, so there are no new updates on microsoft/vscode-remote-release#6746 at this time. |
@bamurtaugh Thanks for the clarification. |
Just a side note for @tensorflow/sigbuild-dockerfile-editors. |
I've added this with a PR in Keras-cv keras-team/keras-cv#893 |
Hi @bhack, @bamurtaugh, @angerson Any update on this PR? Please. Thank you! |
Still waiting a solution from @bamurtaugh and the MS vscode remote team for microsoft/vscode-remote-release#6746 On the TF side I need to check if @MichaelHudgins is still interested in this work. |
Hi @bhack Any update on this PR? Please. Thank you! |
Still waiting for that ticket |
Hi @bhack Any update on this PR? Please. Thank you! |
I know we closed #48679 but as Codespaces is GA now please keep this open so that in the meantime we have a PR where the user could test and bootstrap Github Codespaces and we could collect some feedback.