Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode devcontainer #51439

Closed
wants to merge 14 commits into from
Closed

Vscode devcontainer #51439

wants to merge 14 commits into from

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Aug 12, 2021

I know we closed #48679 but as Codespaces is GA now please keep this open so that in the meantime we have a PR where the user could test and bootstrap Github Codespaces and we could collect some feedback.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 12, 2021
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@bhack bhack marked this pull request as draft August 12, 2021 01:46
@rthadur rthadur self-assigned this Aug 13, 2021
@gbaned gbaned assigned gbaned and unassigned rthadur Aug 17, 2021
@bhack
Copy link
Contributor Author

bhack commented Aug 17, 2021

Keras has already merged its own keras-team/keras@4c9cf43

@bhack
Copy link
Contributor Author

bhack commented Aug 18, 2021

I don't know if Tensorflow team members have this setting enabled, if not it will be hard to test this in Codespaces for them (but It is still ok for Vsocde with remote extension):

https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/enabling-codespaces-for-your-organization

@bhack
Copy link
Contributor Author

bhack commented Aug 18, 2021

/cc @yarri-oss

@bhack
Copy link
Contributor Author

bhack commented Sep 4, 2021

Just a small reminder.
Codespaces is in free trial until September 10, 2021 then we need to pay the VM instance to test this on the Github Codespace VM or with the Vscode browser.

Of course it will be still free to test on our your HW resources with Vscode desktop and the remote extension.

@bhack
Copy link
Contributor Author

bhack commented Mar 21, 2022

@angerson @mihaimaruseac I have minimized he Dockerfile and started to use your new manylinux2014 (currently gpu-only) images.

This new setup is oriented to a Docker rootless installation. See
microsoft/vscode-remote-release#4646
moby/moby#41497

@bhack bhack marked this pull request as ready for review March 23, 2022 14:10
@gbaned gbaned requested a review from angerson March 23, 2022 14:20
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 23, 2022
// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "uname -a",
"mounts": [
"source=tensorflow_cache,target=/root/.cache/bazel/"
Copy link
Contributor Author

@bhack bhack Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chuxel Do you know why also using this the bazel cache is invalidated on every VSCode restart?

Copy link
Contributor Author

@bhack bhack Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've debugged a little more and it is seem to related code insider (daily) update restart. Let me know if you want an upstream ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chuxel I've an upstream ticket now at microsoft/vscode-dev-containers#1453

@bhack
Copy link
Contributor Author

bhack commented Mar 25, 2022

@mihaimaruseac @angerson @yarri-oss You can test this clicking on the code button

immagine

@bhack
Copy link
Contributor Author

bhack commented Mar 25, 2022

Note: with the Codespace "free tier" available disk space (individual account) you will have a no space left on device cause with our manylinux/docker refactory effort we still have only a CUDA embedded image that is very large to run on the "free tier".
See more at tensorflow/build#47

@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 27, 2022
@gbaned gbaned requested review from angerson and removed request for angerson April 19, 2022 09:04
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Apr 19, 2022
@gbaned gbaned requested review from angerson and removed request for angerson May 6, 2022 11:27
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label May 25, 2022
@bamurtaugh
Copy link

Hi folks 👋! I wanted to provide some updates on development containers that might make this PR more interesting (cc @angerson as part of the initial PR thread).

Our team is working on an open dev container specification, so that any user in any tool can create and connect to dev containers. This includes tools beyond VS Code or Codespaces.

We recently released the reference implementation as an open source CLI, in addition to an initial version of the spec. We now have a devcontainers org for these repos and a site where you can read more about this effort: https://containers.dev/.

We also introduced a customizations property in which tool-specific properties live (additional info).

The CLI and spec are both in active development, so they'll continue to evolve, especially with external feedback. We'd love to hear if the spec helps make this PR more viable to become part of TensorFlow, and if there is any feedback or questions that'd make this a better fit - we're more than happy to discuss and collaborate. Thanks!

@bhack
Copy link
Contributor Author

bhack commented Jun 21, 2022

Thank you @bamurtaugh for your team updates I hope that @learning-to-play and @angerson could re-evaluate this.

In the meantime, on my side, one of the major blockers on this is the upstream issue we have at microsoft/vscode-remote-release#6746.

@gbaned
Copy link
Contributor

gbaned commented Jul 18, 2022

@learning-to-play, @angerson, @bhack Any update on this PR? Please. Thank you!

@bhack
Copy link
Contributor Author

bhack commented Aug 5, 2022

@theadactyl Can we try to reply to @bamurtaugh?She is a Vscode PM at Microsoft

Thanks

@bhack
Copy link
Contributor Author

bhack commented Aug 28, 2022

@bamurtaugh Any new on Vscode side for microsoft/vscode-remote-release#6746?

@bamurtaugh
Copy link

Thanks for the ping @bhack!

Our team has been actively focused on specification work and an updated plan for community contributions and the vscode-dev-containers repo moving forward, which we've now outlined in this issue: microsoft/vscode-dev-containers#1589. This includes moving to a couple new repos for images and Features (https://github.com/devcontainers/images, https://github.com/devcontainers/features), and we anticipate to have a similar repo and process for templates/definitions.

Please let me know if you have any questions, thank you!

@bhack
Copy link
Contributor Author

bhack commented Aug 29, 2022

@bamurtaugh For TF we need to find a solution for the VSCode ticket at microsoft/vscode-remote-release#6746

Do you have any update?

@bamurtaugh
Copy link

Apologies for a potential lack of clarity in my original comment. I meant to explain that our team's primary work has been on the dev container spec and the items I highlighted. microsoft/vscode-remote-release#6746 is on the backlog, but spec work has been at the forefront, so there are no new updates on microsoft/vscode-remote-release#6746 at this time.

@bhack
Copy link
Contributor Author

bhack commented Aug 29, 2022

@bamurtaugh Thanks for the clarification.

@bhack
Copy link
Contributor Author

bhack commented Aug 30, 2022

Just a side note for @tensorflow/sigbuild-dockerfile-editors.
Now the devcontainers could be tested with an official Github Action:
https://github.com/devcontainers/ci/blob/main/docs/github-action.md

@bhack
Copy link
Contributor Author

bhack commented Oct 10, 2022

Just a side note for @tensorflow/sigbuild-dockerfile-editors. Now the devcontainers could be tested with an official Github Action: https://github.com/devcontainers/ci/blob/main/docs/github-action.md

I've added this with a PR in Keras-cv keras-team/keras-cv#893

@gbaned
Copy link
Contributor

gbaned commented Dec 14, 2022

Hi @bhack, @bamurtaugh, @angerson Any update on this PR? Please. Thank you!

@bhack
Copy link
Contributor Author

bhack commented Dec 14, 2022

Hi @bhack, @bamurtaugh, @angerson Any update on this PR? Please. Thank you!

Still waiting a solution from @bamurtaugh and the MS vscode remote team for microsoft/vscode-remote-release#6746

On the TF side I need to check if @MichaelHudgins is still interested in this work.

@gbaned
Copy link
Contributor

gbaned commented Feb 16, 2023

Hi @bhack Any update on this PR? Please. Thank you!

@bhack
Copy link
Contributor Author

bhack commented Feb 16, 2023

Still waiting for that ticket

@gbaned
Copy link
Contributor

gbaned commented Jun 23, 2023

Hi @bhack Any update on this PR? Please. Thank you!

@bhack bhack closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:M CL Change Size: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants