Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Start using expect_angular_legacy_material_checkbox #6547

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Bug Fix: Start using expect_angular_legacy_material_checkbox #6547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2f8558
start using expect_angular_legacy_material_checkbox
rileyajones Aug 16, 2023
292e5a9
replace all does not apply formating
rileyajones Aug 16, 2023
92f7ab8
readd the expect_angular_material_checkbox build rule
rileyajones Aug 16, 2023
9c043d2
add new testing rule cl/557590954
rileyajones Aug 16, 2023
317e733
add add dummy rule definition
rileyajones Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tensorboard/webapp/angular/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,24 @@ tf_ts_library(
],
)

# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency.
tf_ts_library(
name = "expect_angular_legacy_material_checkbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you followup with a PR that adds "legacy" to the names of all other relevant targets in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesHollyer and I believe we have found a relatively simple solution to update all the components to the non legacy variants. James is planning on updating all the components, then updating the build rule definitions before syncing them all in at once. I have gone ahead and made the change on my fork but will wait to create a PR rileyajones@0029b45

srcs = [],
deps = [
"@npm//@angular/material",
],
)

# This is a dummy rule used as a @angular/material/checkbox/testing dependency.
tf_ts_library(
name = "expect_angular_material_checkbox_testing",
srcs = [],
deps = [
"@npm//@angular/material",
],
)

# This is a dummy rule used as a @angular/material/button dependency.
tf_ts_library(
name = "expect_angular_material_button",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/metrics/views/right_pane/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ tf_ng_module(
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_slider",
Expand Down Expand Up @@ -58,8 +58,8 @@ tf_ts_library(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_slider",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ tf_ng_module(
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_tabs",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics/actions",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/runs/views/runs_table/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ tf_ng_module(
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/alert",
"//tensorboard/webapp/alert/actions",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_form_field",
"//tensorboard/webapp/angular:expect_angular_material_icon",
Expand Down Expand Up @@ -140,7 +140,7 @@ tf_ts_library(
"//tensorboard/webapp/alert/actions",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_menu",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/settings/_views/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ tf_ng_module(
],
deps = [
"//tensorboard/webapp:tb_polymer_interop_types",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
Expand All @@ -44,8 +44,8 @@ tf_ts_library(
":_views",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/webapp/widgets/data_table/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_checkbox_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/testing:mat_icon",
"//tensorboard/webapp/widgets/custom_modal",
Expand Down