Hparams: Generate metric values for data provider-based session groups. #6543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatbear
approved these changes
Aug 14, 2023
| # Compute the session group's aggregated metrics for each group. | ||
| for group in session_groups: | ||
| if group.sessions: | ||
| # We sort the sessions in a group so that the order is deterministic. |
There was a problem hiding this comment.
Will this sorting be moved to the backend (or backer-end) in the future?
There was a problem hiding this comment.
Now that you mention it, I guess we can already rely on the order returned by the backend, even though theoretically the DataProvider doesn't guarantee any order. In practice this sort is redundant for our use cases.
Anyway, I removed the sorting here (for now).
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Aug 25, 2023
…s. (tensorflow#6543) Generate metric values for hparams plugin `/session_groups` requests when the session groups are generated from DataProvider.read_hyperparameters(). We need to reuse the logic introduced in tensorflow#6539 to generate metric_infos for each session group and also query for scalar values. We reuse the existing logic to join the two collections of data into metric_values for the `/session_groups` request. We also continue the work begun in tensorflow#6541 to improve how we generate sessions - in this case also handling cases where experiment_id is not specified for the session. This became urgently necessary to address in order to get new tests in list_session_groups_test.py to work with existing test data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate metric values for hparams plugin
/session_groupsrequests when the session groups are generated from DataProvider.read_hyperparameters().We need to reuse the logic introduced in #6539 to generate metric_infos for each session group and also query for scalar values. We reuse the existing logic to join the two collections of data into metric_values for the
/session_groupsrequest.We also continue the work begun in #6541 to improve how we generate sessions - in this case also handling cases where experiment_id is not specified for the session. This became urgently necessary to address in order to get new tests in list_session_groups_test.py to work with existing test data.