step selector: add control to settings panel behind feature flag #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japie1235813
changed the title
JamesHollyer
approved these changes
Jun 6, 2022
| @@ -88,6 +88,7 @@ describe('metrics right_pane', () => { | |||
| store.overrideSelector(selectors.getIsFeatureFlagsLoaded, true); | |||
| store.overrideSelector(selectors.getIsMetricsImageSupportEnabled, true); | |||
| store.overrideSelector(selectors.getIsLinkedTimeEnabled, false); | |||
| store.overrideSelector(selectors.getIsDataTableEnabled, false); | |||
There was a problem hiding this comment.
I would like to see a test that shows it does not render when this is false.
There was a problem hiding this comment.
Good catch. Added.
japie1235813
added a commit
that referenced
this pull request
Jun 7, 2022
This is part of the work to wiring the "sticky data table" (aka step selector) to its own feature. Following up #5734, we create the ngrx state and toggle to change the state status, which will be used to turn on/off the feature.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…sorflow#5734) This is part of the work to separate the "sticky data table" (aka step selector) to its own feature. This PR adds the checkbox to enable/disable step selector. The checkbox is hided behind feature flag (enableScalarDataTable).
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
…5742) This is part of the work to wiring the "sticky data table" (aka step selector) to its own feature. Following up tensorflow#5734, we create the ngrx state and toggle to change the state status, which will be used to turn on/off the feature.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…sorflow#5734) This is part of the work to separate the "sticky data table" (aka step selector) to its own feature. This PR adds the checkbox to enable/disable step selector. The checkbox is hided behind feature flag (enableScalarDataTable).
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
…5742) This is part of the work to wiring the "sticky data table" (aka step selector) to its own feature. Following up tensorflow#5734, we create the ngrx state and toggle to change the state status, which will be used to turn on/off the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This is part of the work to separate the "sticky data table" (aka step selector) to its own feature. This PR adds the checkbox to enable/disable step selector. The checkbox is hided behind feature flag (enableScalarDataTable).
Technical description of changes
Add visual component to settings panel and wiring toggle action. (no dispatch action yet)
TODO: add ngrx state to control enabling time selector and plump them together
TODO: consider renaming feature flag