web.bzl: avoid depset union operators #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `+`, `+=`, and `|` operators on depsets, as well as `depset.union`, are deprecated due to performance problems: <bazelbuild/bazel#5817> As of a recent Bazel commit, `.union` is removed is removed entirely, so the operators may be soon on the chopping block: <bazelbuild/bazel@693963f> This commit removes remaining uses from TensorBoard. Google-internal source: <http://cl/283060975> (thanks, @laurentlb!). Test Plan: Running `bazel run //tensorboard` still works. Co-authored-by: Laurent Le Brun <[email protected]> wchargin-branch: remove-depset-union
davidsoergel
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
+,+=, and|operators on depsets, as well asdepset.union,are deprecated due to performance problems:
bazelbuild/bazel#5817
As of a recent Bazel commit,
.unionis removed is removed entirely, sothe operators may be soon on the chopping block:
bazelbuild/bazel@693963f
This commit removes remaining uses from TensorBoard.
Google-internal source: http://cl/283060975 (thanks, @laurentlb!).
Test Plan:
Running
bazel run //tensorboardstill works.Co-authored-by: Laurent Le Brun [email protected]
wchargin-branch: remove-depset-union