frontend: reinstate registration for conditional plugins #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Plugins whose backends are provided via “loaders” rather than the plugins themselves may fail to load. We still want to allow those plugins to display a message in the frontend indicating what must be done to enable them (e.g., update TensorFlow, start a `tfdbg` debugger), which requires registering their frontends unconditionally. This is a short-term hack to retain functionality prior to #2304 (with the minor change that these plugins will now always appear at the end of the list). We’ll want to replace this with a better mechanism when time permits. Fixes #2338. Test Plan: Launch TensorBoard without TensorFlow installed and with no flags other than `--logdir`. Note that the beholder, debugger, hparams, what-if tool, and profile dashboards all have valid entries in the “inactive” dropdown, displaying appropriate help messages. Verify that of the plugins listed in `default.py`, all those provided via loaders now have `registerDashboard` statements. wchargin-branch: register-conditional-plugins
wchargin
changed the title
nfelt
approved these changes
Jun 11, 2019
| @@ -513,6 +513,14 @@ <h3>No Beholder data was found.</h3> | |||
| }, | |||
| }); | |||
|
|
|||
| // TODO(#2338): Remove this, and set up the "no TF" message properly. | |||
There was a problem hiding this comment.
nit: indentation not aligned
wchargin-source: e9af3b0e9db61d4f15d24037fdd2467c8b3f45dc wchargin-branch: register-conditional-plugins
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Plugins whose backends are provided via “loaders” rather than the
plugins themselves may fail to load. We still want to allow those
plugins to display a message in the frontend indicating what must be
done to enable them (e.g., update TensorFlow, start a
tfdbgdebugger),which requires registering their frontends unconditionally.
This is a short-term hack to retain functionality prior to #2304 (with
the minor change that these plugins will now always appear at the end of
the list). We’ll want to replace this with a better mechanism when time
permits.
Fixes #2338.
Test Plan:
Launch TensorBoard without TensorFlow installed and with no flags other
than
--logdir. Note that the beholder, debugger, hparams, what-iftool, and profile dashboards all have valid entries in the “inactive”
dropdown, displaying appropriate help messages.
Verify that of the plugins listed in
default.py, all those providedvia loaders now have
registerDashboardstatements.wchargin-branch: register-conditional-plugins