Skip to content

Commit

Permalink
Bug Fix: Start using expect_angular_legacy_material_checkbox (#6547)
Browse files Browse the repository at this point in the history
## Motivation for features / changes
#6493 Broke our internal sync Googlers see
[cl/557499468](http://cl/557499468)

The issue is related to our internal Angular component migration. New
components are not allowed to rely on the legacy components. Due to this
the new component added in #6493 uses the non legacy checkbox. However,
our dependency remapping always remaps dependencies on material_checkbox
to legacy_material_checkbox.

To fix this I am changing the name of the remapping rule in
[cl/557515881](http://cl/557515881) and adjusting all the OSS usage
EXCEPT for the usage in filter_dialog.

[cl/557590954](http://cl/557590954) is also required to map the testing
dependency needed to use `MatCheckboxHarness`
  • Loading branch information
rileyajones authored Aug 17, 2023
1 parent 6627a7f commit 7e30969
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 7 deletions.
18 changes: 18 additions & 0 deletions tensorboard/webapp/angular/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,24 @@ tf_ts_library(
],
)

# This is a dummy rule used as a @angular/material/legeacy_checkbox dependency.
tf_ts_library(
name = "expect_angular_legacy_material_checkbox",
srcs = [],
deps = [
"@npm//@angular/material",
],
)

# This is a dummy rule used as a @angular/material/checkbox/testing dependency.
tf_ts_library(
name = "expect_angular_material_checkbox_testing",
srcs = [],
deps = [
"@npm//@angular/material",
],
)

# This is a dummy rule used as a @angular/material/button dependency.
tf_ts_library(
name = "expect_angular_material_button",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/metrics/views/right_pane/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ tf_ng_module(
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_slider",
Expand Down Expand Up @@ -58,8 +58,8 @@ tf_ts_library(
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button_toggle",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_select",
"//tensorboard/webapp/angular:expect_angular_material_slider",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ tf_ng_module(
deps = [
"//tensorboard/webapp:app_state",
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_tabs",
"//tensorboard/webapp/metrics:types",
"//tensorboard/webapp/metrics/actions",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/runs/views/runs_table/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ tf_ng_module(
"//tensorboard/webapp:selectors",
"//tensorboard/webapp/alert",
"//tensorboard/webapp/alert/actions",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_form_field",
"//tensorboard/webapp/angular:expect_angular_material_icon",
Expand Down Expand Up @@ -140,7 +140,7 @@ tf_ts_library(
"//tensorboard/webapp/alert/actions",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_input",
"//tensorboard/webapp/angular:expect_angular_material_menu",
Expand Down
4 changes: 2 additions & 2 deletions tensorboard/webapp/settings/_views/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ tf_ng_module(
],
deps = [
"//tensorboard/webapp:tb_polymer_interop_types",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
Expand All @@ -44,8 +44,8 @@ tf_ts_library(
":_views",
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_legacy_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_button",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_dialog",
"//tensorboard/webapp/angular:expect_angular_material_icon",
"//tensorboard/webapp/angular:expect_angular_material_input",
Expand Down
1 change: 1 addition & 0 deletions tensorboard/webapp/widgets/data_table/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ tf_ts_library(
"//tensorboard/webapp/angular:expect_angular_cdk_testing_testbed",
"//tensorboard/webapp/angular:expect_angular_core_testing",
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
"//tensorboard/webapp/angular:expect_angular_material_checkbox_testing",
"//tensorboard/webapp/angular:expect_angular_platform_browser_animations",
"//tensorboard/webapp/testing:mat_icon",
"//tensorboard/webapp/widgets/custom_modal",
Expand Down

0 comments on commit 7e30969

Please sign in to comment.