Skip to content

Commit

Permalink
Tweak some patch and upgrade documentation. (#6520)
Browse files Browse the repository at this point in the history
Make some minor fixes/additions to documentation related to upgrading
npm dependencies and generating patch files.
  • Loading branch information
bmd3k authored Aug 8, 2023
1 parent 165ef3b commit 1e7f1c9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ to be edited by hand.
4. Rebuild and test TensorBoard to make sure it works:
* `rm -rf node_modules; bazel clean --expunge; yarn`
* `bazel run tensorboard --logdir <your favorite logdir>`
* `bazel run tensorboard -- --logdir <your favorite logdir>`
* `bazel test --test_output=errors tensorboard/webapp/... tensorboard/components/... tensorboard/plugins/...`
## Updating rules_nodejs
Expand Down
9 changes: 8 additions & 1 deletion patches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@ We use [patch-package](https://www.npmjs.com/package/patch-package) to apply
TensorBoard-specific patches to some of our npm/yarn dependencies.

To regenerate @bazel/concatjs patch:
* `vi "node_modules/@bazel/concatjs/web_test/karma.conf.js"`
* `vi node_modules/@bazel/concatjs/web_test/karma.conf.js`
* make edits
* `yarn patch-package "@bazel/concatjs"`
* update the WORKSPACE file with the name of the new patch file


To regenerate @angular/build-tooling patch:
* `vi node_modules/@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs`
* make edits
* `yarn patch-package "@angular/build-tooling"`
* update the WORKSPACE file with the name of the new patch file

0 comments on commit 1e7f1c9

Please sign in to comment.