[Feat]combine cpu and gpu wheel #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
force-pushed
the
hkv_hashtable_ops
branch
2 times, most recently
from
36ea21a to
55a594e
Compare
rhdong
changed the title
rhdong
previously approved these changes
Aug 30, 2024
README.md
Outdated
| @@ -76,7 +76,7 @@ run the following: | |||
| pip install tensorflow-recommenders-addons | |||
| ``` | |||
|
|
|||
| By default, CPU version will be installed. To install GPU version, run the following: | |||
| Before the release of combined CPU and GPU version, to install GPU version, run the following: | |||
There was a problem hiding this comment.
Better to explain more clearly, for example, the specific version(0.7.x) after which we make this change.
|
Hey @MoFHeka pls review it when you feel convenient, basically, it's LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
combine cpu and gpu wheel so that you only need pip install tensorflow-recommenders-addons
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*