Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] add HkvHashTableExportWithScores op #447

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

jq
Copy link
Collaborator

@jq jq commented Jul 16, 2024

Description

Fix missing HkvHashTableExportWithScores op
with help/collaborate from @MoFHeka and zhiheng

Fix the incompatiblity with new tf.keras.optimizers.Adagrad, it pass 0 shape tensor during the init, and we fix it by init with 0
Reduce the default buffer_size of FileSystemSaver to 4k

Brief Description of the PR:

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@jq jq requested a review from rhdong as a code owner July 16, 2024 02:58
@jq jq force-pushed the hkv_hashtable_ops branch 8 times, most recently from d8eda8f to a846b09 Compare July 17, 2024 21:40
MoFHeka
MoFHeka previously approved these changes Jul 18, 2024
Copy link
Collaborator

@MoFHeka MoFHeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong force-pushed the hkv_hashtable_ops branch from 059714d to 074a5e7 Compare July 20, 2024 00:09
@rhdong rhdong merged commit ddd7586 into tensorflow:master Jul 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants