[fix]remove tracking of shadow var id #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lifann
reviewed
Jul 9, 2024
| @@ -118,7 +118,7 @@ def __init__(self, | |||
| dtype=self.params.key_dtype, | |||
| distribute_strategy=distribute_strategy, | |||
| shape=tensor_shape.TensorShape(None)) | |||
| self._track_trackable(self.ids, ids_name, overwrite=False) | |||
| #self._track_trackable(self.ids, ids_name, overwrite=False) | |||
There was a problem hiding this comment.
Feel free to remove it if tests and demos runs ok.
There was a problem hiding this comment.
amazon data is broken, https://github.com/tensorflow/datasets/pull/5047/files#diff-f1d0135661585ce9ff2864f0f316afbc1d88eb09fd3e9d7389bb63bb398f1603 and not yet merge
the other example worked.
There was a problem hiding this comment.
I think it's valid if movielens-1m-keras pass
jq
force-pushed
the
tracking
branch
2 times, most recently
from
b884812 to
cd4e6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*