[Fix] Stack overflow in Redis Backend and RestrictPolicy couldn't be saved when using DE embedding layer. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFHeka
changed the title
Closed
MoFHeka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix tmpDirPath with fixed size may cause stack overflow in Redis backend. The char size of the entered file path may exceed 1024. Fixes #405
Fix restrict_policy wasn't tracked when using Embedding layer. Fixes #385
Type of change
Checklist:
How Has This Been Tested?
When using redis backend, enter a non-existent file path that is longer than 1024.