add reserved_key_start_bit option to config hkv #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
force-pushed
the
hkv
branch
2 times, most recently
from
e452633 to
4190c14
Compare
|
@LinGeLin for review |
jq
force-pushed
the
hkv
branch
5 times, most recently
from
c32b529 to
a9e1edc
Compare
MoFHeka
requested changes
May 22, 2024
| @@ -308,6 +308,7 @@ REGISTER_OP(PREFIX_OP_NAME(HkvHashTableOfTensors)) | |||
| .Attr("max_hbm_for_vectors: int = 0") | |||
| .Attr("step_per_epoch: int = 0") | |||
| .Attr("strategy: int = 0") | |||
| .Attr("reserved_key_start_bit: int = 0") | |||
There was a problem hiding this comment.
default value of reserved_key_start_bit is better to be same as python code which is 1.
There was a problem hiding this comment.
NVIDIA-Merlin/HierarchicalKV#191 set the default to 0
| @@ -79,6 +79,7 @@ def __init__( | |||
| evict_strategy=HkvEvictStrategy.LRU, | |||
| step_per_epoch=0, | |||
| gen_scores_fn=None, | |||
| reserved_key_start_bit=0, | |||
There was a problem hiding this comment.
A simple explanation of config reserved_key_start_bit in document docs/api_docs/tfra/dynamic_embedding/HkvHashTableConfig.md, that would be better.
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*