[feature] ragged tensor support and enable ShadowVariable look up for safe_embedding_lookup_sparse #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq
force-pushed
the
master
branch
2 times, most recently
from
1652941 to
84d1c40
Compare
jq
force-pushed
the
master
branch
14 times, most recently
from
37e2bbe to
13fa638
Compare
jq
force-pushed
the
master
branch
3 times, most recently
from
2df0e53 to
2aea76e
Compare
rhdong
reviewed
Apr 17, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/ragged_embedding_ops.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Apr 17, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/ragged_embedding_ops.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Apr 17, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/shadow_embedding_ops.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Apr 17, 2024
tensorflow_recommenders_addons/dynamic_embedding/python/ops/shadow_embedding_ops.py
Outdated
Show resolved
Hide resolved
rhdong
reviewed
Apr 17, 2024
| return embeddings | ||
|
|
||
|
|
||
| def embedding_lookup_sparse( |
There was a problem hiding this comment.
In the spirit of TensorFlow API designation, may we merge the logic of processing the ragged tensor into the API with the same name in the dynamic_embedding_ops.py.(it is up on you, considering the complexity)
There was a problem hiding this comment.
thanks for review, tf's raggedtensor also live in seperated file, so this maybe ok?
jq
force-pushed
the
master
branch
4 times, most recently
from
c737b3d to
4280d1d
Compare
jq
force-pushed
the
master
branch
5 times, most recently
from
d1bbbec to
ba85400
Compare
…pport raggedtensor
This was referenced Apr 19, 2024
jq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes # (issue)
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*