Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Supported hkv cpu operator base cuckoo cpu operator #387

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

LinGeLin
Copy link
Contributor

@LinGeLin LinGeLin commented Mar 6, 2024

Because the underlying cuckoo gpu operator is changed to hkv operator, if a user originally uses cuckoo gpu training but does not have a gpu when serving, the inference service will fail。

Brief Description of the PR:

Fixes # (issue)

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*

@rhdong
Copy link
Member

rhdong commented Mar 24, 2024

Maybe we need to open some test cases for this PR.

@LinGeLin LinGeLin force-pushed the hkv_cpu branch 3 times, most recently from 685326f to 240d950 Compare March 26, 2024 06:37
@LinGeLin
Copy link
Contributor Author

LinGeLin commented Mar 26, 2024

Maybe we need to open some test cases for this PR.

Some cpu test cases have been added, but if need ci to run these cases, it looks like need to add another ci node, is that necessary?

Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit 2a15cbf into tensorflow:master Apr 1, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants