Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix error that self._saveable_fn would not exist when checkpoint param is False. #310

Merged
merged 2 commits into from
Mar 26, 2023
Merged

[Fix] fix error that self._saveable_fn would not exist when checkpoint param is False. #310

merged 2 commits into from
Mar 26, 2023

Conversation

MoFHeka
Copy link
Collaborator

@MoFHeka MoFHeka commented Mar 25, 2023 •
edited
Loading

Description

Fix error that self._saveable_fn would not exist when checkpoint param is False.
Also make BasicEmbedding call function more grace.

Type of change

  • Bug fix
  • New Tutorial
  • Updated or additional documentation
  • Additional Testing
  • New Feature

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running yapf
    • By running clang-format
  • This PR addresses an already submitted issue for TensorFlow Recommenders-Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

use get_variable calling and set checkpoint=False.

@MoFHeka MoFHeka requested a review from rhdong as a code owner March 25, 2023 16:50
rhdong
rhdong approved these changes Mar 26, 2023
View reviewed changes
Copy link
Member

@rhdong rhdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhdong rhdong merged commit f8ab384 into tensorflow:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhdong rhdong rhdong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoFHeka @rhdong