[Fix]Rehash gpu table before importing values and reduce size kernel call. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @acmore , sorry for lately replying, we should discuss on the PR and help to merge it ASAP. Could you send your WeChat account to my mail([email protected])? Thank you! |
|
HI @rhdong sent |
|
Hi @acmore, this PR is LGTM. Before merging it, please squash all of the commits into one and resolve the conflicts and clang check failure, thank you! |
|
Hi @rhdong I updated the mr, but I am not sure how to do squash properly. Maybe you could select Squash and merge commit option when you merge this mr? Thanks |
rhdong
approved these changes
Sep 22, 2022
rhdong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix gpu table import issues. It will expand the table to appropriate size before importing values. And it will try to minimize the number of calls to size kernel.
Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*