[feat] Add redis_hash_tags_hypodispersion and using_hash_storage_slice to redis backend config. Change redis_connection_mode config, now redis_connection_mode = 2 will be standalone mode. #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFHeka
changed the title
MoFHeka
changed the title
MoFHeka
force-pushed
the
redis-dev
branch
3 times, most recently
from
7836389 to
554054c
Compare
MoFHeka
changed the title
rhdong
reviewed
May 26, 2022
tensorflow_recommenders_addons/dynamic_embedding/python/ops/redis_table_ops.py
Show resolved
Hide resolved
Distribution of storag_slice tag will be hypodispersion in 16354 regardless cluster slot, but still depends on redis_hash_tags_import/runtime if they aren't empty. [feat] Add using_hash_storage_slice in redis config. If True, IDs will be calculated hash(CRC32) value and then MOD to decide which bucket number they belong to. If False, only calculate the remainder. [feat] Change redis_connection_mode config now redis_connection_mode = 2 will be standalone mode. [fix] Fix no redis sentinel password option in redis backend config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add redis_hash_tags_hypodispersion to redis backend config.
If True, Distribution of storag_slice tag will be hypodispersion in 16354 regardless cluster slot, but still depends on redis_hash_tags_import/runtime if they aren't empty.
Add using_hash_storage_slice in redis config.
If True, IDs will be calculated hash(CRC32) value and then MOD to decide which bucket number they belong to.
If False, only calculate the remainder.
Change redis_connection_mode config, now redis_connection_mode = 2 will be standalone mode.
Also fix no redis sentinel password option in redis backend config.
Type of change
Checklist:
How Has This Been Tested?
set redis_hash_tags_hypodispersion/using_hash_storage_slice to true or false in redis config.