[feat] bpv2 (update de by adding delta instead of setting) #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhdong
reviewed
Aug 9, 2021
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_variable.py
Outdated
Show resolved
Hide resolved
|
Hi @nrailgun ,thank you for your excellent job, that 's really useful optimization. |
rhdong
reviewed
Aug 9, 2021
Lifann
reviewed
Aug 9, 2021
Lifann
reviewed
Aug 10, 2021
tensorflow_recommenders_addons/dynamic_embedding/python/ops/dynamic_embedding_variable.py
Outdated
Show resolved
Hide resolved
nrailg
force-pushed
the
nrwu/bpv2
branch
2 times, most recently
from
cad9938 to
c8b84e4
Compare
nrailg
changed the title
nrailg
force-pushed
the
nrwu/bpv2
branch
3 times, most recently
from
34e3547 to
31b32dd
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
DE of tfra used to update embeddings / slots of embeddings by setting values, which introduces race condition problem among workers.
This PR solves this problem by updating MHTs of DE using the
CuckooHashTable.Accum.Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
./demo/bpv2/*./tensorflow_recommenders_addons/dynamic_embedding/python/kernel_tests/dynamic_embedding_optimizer_test.py