convert values to const

tensorflow · Jul 13, 2022 · bdd5da4 · bdd5da4
1 parent f4e5ecd
commit bdd5da4
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...flow_recommenders_addons/dynamic_embedding/core/kernels/lookup_impl/lookup_table_op_cpu.h b/...flow_recommenders_addons/dynamic_embedding/core/kernels/lookup_impl/lookup_table_op_cpu.h
@@ -258,7 +258,8 @@ class TableWrapperOptimized final : public TableWrapperBase<K, V> {
     const string tmp_file = filepath + ".tmp";
     TF_RETURN_IF_ERROR(hdfs.NewWritableFile(tmp_file, &writer));
 
-    uint32 record_len = sizeof(K) + sizeof(V) * dim;
+    const uint32 value_len = sizeof(V) * dim;
+    const uint32 record_len = sizeof(K) + value_len;
     uint64 pos = 0;
     uint8 content[buffer_size + record_len];
 
@@ -268,7 +269,7 @@ class TableWrapperOptimized final : public TableWrapperBase<K, V> {
 
       const auto& jt = it->second.data();
       std::memcpy(content + pos + sizeof(K), reinterpret_cast<uint8*>(jt),
-                  sizeof(V) * dim);
+                  value_len);
 
       pos += record_len;
       if (pos > buffer_size) {
@@ -304,8 +305,10 @@ class TableWrapperOptimized final : public TableWrapperBase<K, V> {
     TF_RETURN_IF_ERROR(hdfs.GetFileSize(filepath, &file_size));
 
     tstring content;
-    uint64 record_len = sizeof(K) + sizeof(V) * dim;
+    const uint32 value_len = sizeof(V) * dim;
+    const uint32 record_len = sizeof(K) + value_len;
     uint64 i = 0;
+
     while (i < file_size) {
       TF_RETURN_IF_ERROR(reader.ReadNBytes(record_len, &content));
       K k;
@@ -314,7 +317,7 @@ class TableWrapperOptimized final : public TableWrapperBase<K, V> {
       ValueType value_vec;
       std::memcpy(value_vec.data(),
                   reinterpret_cast<uint8*>(content.data()) + sizeof(K),
-                  sizeof(V) * dim);
+                  value_len);
       table_->insert_or_assign(k, value_vec);
       i += record_len;
     }