Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vae.py link to an active link #1572

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

LukeWood
Copy link
Contributor

@LukeWood LukeWood commented Jun 6, 2022

Update vae.py link to an active link. the current link points to a missing file.

Update vae.py link to an active link.  the current link points to a missing file.
@ColCarroll
Copy link
Collaborator

Thanks for this -- we should definitely do something with it. vae.py used to exist, but the keras API changed enough that it no longer worked. In the same section, the LDA link is also broken (for the same reason). I think I'd prefer to just remove both links from the README for now -- do you have time to update the PR to do that?

@LukeWood
Copy link
Contributor Author

LukeWood commented Jun 7, 2022

Thanks for this -- we should definitely do something with it. vae.py used to exist, but the keras API changed enough that it no longer worked. In the same section, the LDA link is also broken (for the same reason). I think I'd prefer to just remove both links from the README for now -- do you have time to update the PR to do that?

Sure, give me a few minutes to get to my desk.

@LukeWood
Copy link
Contributor Author

LukeWood commented Jun 7, 2022

Thanks for this -- we should definitely do something with it. vae.py used to exist, but the keras API changed enough that it no longer worked. In the same section, the LDA link is also broken (for the same reason). I think I'd prefer to just remove both links from the README for now -- do you have time to update the PR to do that?

Curious what the API change was that broke it. We typically hold backwards compatibility in the highest regard. (Keras team member here for reference)

@ColCarroll
Copy link
Collaborator

Sorry, pointed the (non-blaming!) finger too soon: this was the commit which was cleanup after getting rid of tensorflow Estimator module.

@LukeWood
Copy link
Contributor Author

LukeWood commented Jun 7, 2022

Sorry, pointed the (non-blaming!) finger too soon: this was the commit which was cleanup after getting rid of tensorflow Estimator module.

Absolutely no worries, I was genuinely curious as we do occasionally put out breaking changes. If it was due to one of those I was going to offer to fix the scripts, as I am extremely familiar with the workarounds to get around our breaking changes.

Estimator on the other hand, I cannot offer up fixing those scripts.

Cheers!

@copybara-service copybara-service bot merged commit 113d0a0 into tensorflow:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants