Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #9927: pascal_voc_detection_metrics low scores for first catategory in label_map #11084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DEV4INO
Copy link

@DEV4INO DEV4INO commented Sep 9, 2023

Only add 1 if there is at least one element greater than 0 per row for ground-truth
See also issue #9927
This change should reviewed in detail, maybe this could have side effects, I am not aware of.

Description

This bug could results in wrong results and should be fixed

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

Tests

Evaluate results with metric pascal voc evaluator that has unusual low scores on the first class.
you can stop on the changed line and see if there are row entries in the ground truth variable with only zeros

See also #9927

Test Configuration:

Checklist

…ategory in label_map

Only add 1 if there is at least one element greater than 0 per row
@DEV4INO DEV4INO requested a review from jch1 as a code owner September 9, 2023 03:39
@diaconumadalina
Copy link

Hello everyone, I'm Mada, and I'm eager to begin contributing to open-source projects. TensorFlow seems like an excellent place to start. Could someone please help me determine if a specific issue is still open, and if so, guide me on how to proceed with it? I appreciate any assistance provided.

@laxmareddyp laxmareddyp added the models:research models that come under research directory label Jan 9, 2024
@DEV4INO
Copy link
Author

DEV4INO commented Jul 7, 2024

@diaconumadalina sorry for my late response
To be honest, I’m not entirely sure. This issue occasionally appears in relation to #9927, and I first encountered it while working on an AI model about two years ago. If I have the opportunity, I could implement some tests to verify this. However, I’m not certain if this is still a requirement, given that the object detection component seems somewhat outdated. The most recent model added is mobilenetv3small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models:research models that come under research directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants