Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use batch.num.messages config in KafkaGroupReadableResource::Next #1460

Merged
merged 3 commits into from
Jun 19, 2021
Merged

use batch.num.messages config in KafkaGroupReadableResource::Next #1460

merged 3 commits into from
Jun 19, 2021

Conversation

kvignesh1420
Copy link
Member

This PR addresses #1458 by allowing the users to set the number of records fetched from kafka per next() on KafkaGroupIODataset and KafkaBatchIODataset. (Defaults to 1024).

@kvignesh1420 kvignesh1420 marked this pull request as draft June 16, 2021 14:19
add test case for batch.num.messages
@kvignesh1420 kvignesh1420 marked this pull request as ready for review June 16, 2021 15:33
@kvignesh1420 kvignesh1420 changed the title use max.poll.records config in KafkaGroupReadableResource::Next use batch.num.messages config in KafkaGroupReadableResource::Next Jun 16, 2021
@kvignesh1420 kvignesh1420 requested a review from yongtang June 16, 2021 16:48
@kvignesh1420
Copy link
Member Author

cc: @yongtang

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@yongtang yongtang merged commit 94a15d0 into tensorflow:master Jun 19, 2021
@kvignesh1420 kvignesh1420 deleted the max-poll-record-config branch June 19, 2021 20:32
dopiera pushed a commit to Unoperate/tensorflow_io that referenced this pull request Dec 3, 2021
…nsorflow#1460)

* use max.poll.records config in KafkaGroupReadableResource

* switch to batch.num.messages

add test case for batch.num.messages

* fix failing kafka test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants