Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Relativisitc Average GAN Loss #46

Merged
merged 9 commits into from
Sep 7, 2021

Conversation

nivedwho
Copy link
Contributor

Added two functions

  • ragan_generator() for calculating generator loss.
  • ragan_discriminator() for calculating discriminator loss

and a class RelativisticAverageLoss for testing the two functions.

@googlebot googlebot added the cla: yes to pull into main branch, I think? label Aug 17, 2021
Copy link
Contributor

@joel-shor joel-shor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name changes only. Other than that, looks great. Please ping me when this is completed!

tensorflow_gan/python/losses/losses_impl.py Outdated Show resolved Hide resolved
tensorflow_gan/python/losses/losses_impl.py Outdated Show resolved Hide resolved
tensorflow_gan/python/losses/losses_impl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@joel-shor joel-shor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

You also need to add your symbols to 'exposed_symbols_test' and 'tuple_losses.py'. Thanks!

tensorflow_gan/python/losses/losses_impl.py Show resolved Hide resolved
@joel-shor joel-shor self-requested a review August 26, 2021 16:26
Copy link
Contributor

@joel-shor joel-shor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ot make sure this gets it:

  1. Please change the arguments so they're standard
  2. Please add the symbols to 'exposed_symbols_test'

Copy link
Contributor

@joel-shor joel-shor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line docstring summary should end with ".", ".)", "?", or "!" [g-short-docstring-punctuation]
//depot/google3/third_party/py/tensorflow_gan/python/losses/tuple_losses_test.py:272:1
One-line docstring summary should end with ".", ".)", "?", or "!" [g-short-docstring-punctuation]
//depot/google3/third_party/py/tensorflow_gan/python/losses/tuple_losses_test.py:292:1

@joel-shor
Copy link
Contributor

joel-shor commented Sep 1, 2021 via email

@copybara-service copybara-service bot merged commit 9ad6bdc into tensorflow:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes to pull into main branch, I think?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants