-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Relativisitc Average GAN Loss #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name changes only. Other than that, looks great. Please ping me when this is completed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
You also need to add your symbols to 'exposed_symbols_test' and 'tuple_losses.py'. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just ot make sure this gets it:
- Please change the arguments so they're standard
- Please add the symbols to 'exposed_symbols_test'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One-line docstring summary should end with ".", ".)", "?", or "!" [g-short-docstring-punctuation]
//depot/google3/third_party/py/tensorflow_gan/python/losses/tuple_losses_test.py:272:1
One-line docstring summary should end with ".", ".)", "?", or "!" [g-short-docstring-punctuation]
//depot/google3/third_party/py/tensorflow_gan/python/losses/tuple_losses_test.py:292:1
Responded!
…On Wed, Sep 1, 2021 at 11:58 AM Nived P A ***@***.***> wrote:
@nivedwho <https://github.com/nivedwho> requested your review on: #46
<#46> Added Relativisitc Average
GAN Loss .
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#46 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN567DTDGDW6BCISRCNFR3T7ZZW7ANCNFSM5CJJWNRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Added two functions
and a class RelativisticAverageLoss for testing the two functions.