-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App screenshot added to Image classification android example #329
base: master
Are you sure you want to change the base?
App screenshot added to Image classification android example #329
Conversation
@@ -17,7 +17,8 @@ These instructions walk you through building and running the demo on an Android | |||
device. For an explanation of the source, see | |||
[TensorFlow Lite Android image classification example](EXPLORE_THE_CODE.md). | |||
|
|||
<!-- TODO(b/124116863): Add app screenshot. --> | |||
<img src= https://github.com/SunitRoy2703/examples/raw/image-classification-android-screenshot/lite/examples/image_classification/android/screenshot.png width="350" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add an image.
Please use:
src="https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png"
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing @lintian06
I have removed the image and changed the image src to "https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please surround src with "". Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @lintian06
I have added image src with "" surrounding it.
@@ -17,7 +17,8 @@ These instructions walk you through building and running the demo on an Android | |||
device. For an explanation of the source, see | |||
[TensorFlow Lite Android image classification example](EXPLORE_THE_CODE.md). | |||
|
|||
<!-- TODO(b/124116863): Add app screenshot. --> | |||
<img src= "https://www.tensorflow.org/lite/examples/image_classification/images/android_banana.png" width="350" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to the PR!
my pleasure! |
Any update on this? @lintian06 |
added and shown the App screenshot of the Image classification android example