Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to follow the change of Keras v3.5.0 #2356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaesuk
Copy link

@jaesuk jaesuk commented Feb 10, 2025

Description

Keras has introduced a new way of what/how get_file() returns since v3.5.0 with this commit. Therefore, the tutorial is not working anymore with the latest TensorFlow with the affected Keras, for instance, TensorFlow v2.18.0 and Keras v3.8.0 are currently installed in Colab and it failed to get the data file as in the screenshot below.
Screenshot 2025-02-10 at 7 17 33 PM
It could be dealt with in the better way to consider the older versions, though, it's a bit off-track from the tutorial's purpose itself. So, this PR starts from the shortest version.

Please feel free to correct me. I'm usually making a mistake.
Thank you! :D

References

Keras has introduced a new way of what/how `get_file()` returns since v3.5.0.
Therefore, the tutorial is not working anymore with the latest TensorFlow
with the affected Keras. The details are below.

- keras-team/keras@v3.5.0...master
- keras-team/keras@dcefb13
@jaesuk jaesuk requested a review from a team as a code owner February 10, 2025 15:25
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch/change-to-follow-the-change-of-keras-v3.5.0

@8bitmp3
Copy link
Contributor

8bitmp3 commented Feb 10, 2025

@MarkDaoust @markmcd PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants