Public function to register custom ops #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had time for a full review, but at first glance looks like a good strategy. @guillaumekln could you take a look when time allows and see if this covers the issue from your perspective. |
guillaumekln
reviewed
Mar 5, 2020
|
Thanks a lot for the review! Let me fix all that. |
guillaumekln
previously approved these changes
Mar 5, 2020
|
@seanpmorgan Do you want to take a second look before merging? |
|
This pull request will be discussed at the meeting tonight I believe. |
|
@gabrieldemarmiesse Conflicts and then LGTM. Per discussion we'll want to work toward registering Keras objects in a similar manner |
Let's do that in another pull request to make the review easier. |
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Added public functions to register everything. * Removed decorator * Revert "Removed decorator" This reverts commit ebea5bd. * Added some tests. * Added the two register. * Removed unused variables. * Private func. * Explicit modules. * FLake8 * Added documentation. * Remove useless setup method. * Black/ * Format BUILD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1151
I'll open an issue to track the registering of keras objects with this function. It's there for future backward compatibility.