Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Use torch in mnist example #927

Merged
merged 8 commits into from
Sep 29, 2022
Merged

Conversation

VoVAllen
Copy link
Member

Signed-off-by: Jinjing.Zhou [email protected]

Fix #881

Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
@muniu-bot muniu-bot bot requested a review from aseaday September 20, 2022 10:18
@muniu-bot muniu-bot bot added the approved label Sep 20, 2022
Signed-off-by: Jinjing.Zhou <[email protected]>
@VoVAllen VoVAllen changed the title example: Use torch in mnist example WIP example: Use torch in mnist example Sep 20, 2022
@VoVAllen VoVAllen changed the title WIP example: Use torch in mnist example example: Use torch in mnist example Sep 26, 2022
gaocegege
gaocegege previously approved these changes Sep 26, 2022
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@muniu-bot muniu-bot bot added the lgtm label Sep 26, 2022
@kemingy
Copy link
Member

kemingy commented Sep 29, 2022

Please fix the lint with make envd-fmt

Signed-off-by: Jinjing.Zhou <[email protected]>
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Sep 29, 2022
@muniu-bot
Copy link

muniu-bot bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy, VoVAllen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VoVAllen,gaocegege,kemingy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot merged commit 0b73548 into tensorchord:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: MNIST example doesn't work on Apple Silicon MacOS
3 participants