Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: v1 #1284

Merged
merged 3 commits into from
Dec 15, 2022
Merged

doc: v1 #1284

merged 3 commits into from
Dec 15, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Dec 8, 2022

Signed-off-by: Keming [email protected]

cc @VoVAllen

It's still ugly. The class method has exactly the same indent as a normal function or a class object. Not sure if we can fix it.

Signed-off-by: Keming <[email protected]>
@kemingy kemingy marked this pull request as ready for review December 8, 2022 10:26
@kemingy kemingy requested a review from VoVAllen as a code owner December 8, 2022 10:26
@VoVAllen
Copy link
Member

VoVAllen commented Dec 8, 2022

@VoVAllen
Copy link
Member

VoVAllen commented Dec 8, 2022

You can change it if needed

@kemingy
Copy link
Member Author

kemingy commented Dec 8, 2022

I think it's set at https://github.com/tensorchord/envd-docs/blob/main/hack/api/render.py#L37-L43

Yes, but the header level is not sufficient. I wonder if this can generate the indents like the Python sphinx doc: https://0b01001001.github.io/spectree/plugins.html

We can merge this one and find a better way letter for the envd-doc repo.

@VoVAllen
Copy link
Member

VoVAllen commented Dec 9, 2022

I don't think we need to make them as sub class. Does sub module work?

@kemingy
Copy link
Member Author

kemingy commented Dec 14, 2022

This change should work with tensorchord/envd-docs#206.

I hope we can add the module path to the function title, but sadly there is a bug in the NiklasRosenstein/pydoc-markdown#276

@gaocegege
Copy link
Member

Could you please give a preview link here?

@gaocegege
Copy link
Member

gaocegege commented Dec 15, 2022

About the markdown or html generated from the v1 API

@kemingy
Copy link
Member Author

kemingy commented Dec 15, 2022

image

@kemingy
Copy link
Member Author

kemingy commented Dec 15, 2022

Screenshot updated. I guess we can also patch the pydoc-markdown if necessary.

@gaocegege
Copy link
Member

I am wondering where to tell users that the default version is v0, and they can use # syntax=v1 to move to v1.

@gaocegege
Copy link
Member

But not related to this PR. LGTM

@kemingy
Copy link
Member Author

kemingy commented Dec 15, 2022

I am wondering where to tell users that the default version is v0, and they can use # syntax=v1 to move to v1.

I added to every header of the v1 module doc. See the warning in the screenshot.

@gaocegege
Copy link
Member

/lgtm

@muniu-bot muniu-bot bot added the lgtm label Dec 15, 2022
@kemingy kemingy merged commit 1fec54e into tensorchord:main Dec 15, 2022
@kemingy kemingy deleted the doc_v1 branch December 15, 2022 03:15
@Juni66623
Copy link

Thu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The base os image version is not correct
4 participants