Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use horust as the dev container supervisor #1051

Merged
merged 8 commits into from
Oct 20, 2022
Merged

feat: use horust as the dev container supervisor #1051

merged 8 commits into from
Oct 20, 2022

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Oct 19, 2022

@muniu-bot
Copy link

muniu-bot bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muniu-bot muniu-bot bot added the approved label Oct 19, 2022
@kemingy
fix daemon
d4e0d72 
Signed-off-by: Keming <[email protected]>
@kemingy
change to ENVD_WORKDIR
2843cd7 
Signed-off-by: Keming <[email protected]>
@kemingy
keep env
c7eeee4 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy marked this pull request as ready for review October 19, 2022 11:54
@kemingy kemingy requested a review from zwpaper as a code owner October 19, 2022 11:54
@muniu-bot muniu-bot bot requested a review from gaocegege October 19, 2022 11:54
@kemingy
bypass custom image
7b67a4c 
Signed-off-by: Keming <[email protected]>
@kemingy
fix lint
0bb26de 
Signed-off-by: Keming <[email protected]>
@gaocegege
Copy link
Member

Hi, is it ready to review?

@kemingy
Copy link
Member Author

kemingy commented Oct 20, 2022

Hi, is it ready to review?

yes, PTAL

gaocegege
gaocegege reviewed Oct 20, 2022
View reviewed changes
pkg/lang/ir/editor.go Show resolved Hide resolved
pkg/lang/ir/compile.go Outdated Show resolved Hide resolved
base-images/horust.Dockerfile Outdated Show resolved Hide resolved
@gaocegege
Copy link
Member

/lgtm

Thanks for your contribution! 🎉 👍

@muniu-bot muniu-bot bot added the lgtm label Oct 20, 2022
@gaocegege gaocegege merged commit cd5cf52 into tensorchord:main Oct 20, 2022
@kemingy kemingy deleted the horust branch October 22, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees

@gaocegege gaocegege

Labels
approved lgtm
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Better management of entrypoint process
2 participants
@kemingy @gaocegege