Failing test to illustrate a problem with how TLDR gathers tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLDR gathers tests by recursively looking for descendants of the TLDR class. If you have multiple Rake tasks that look in different places for tests, that's all well and good, but the first Rake task that runs (because it's all in the same process) will load all of its tests and the second Rake task will, of course, find them, because they're still defined. Decoupling path from test definition is generally good but in this particular case it is not fantastic. Makes me wonder if we should go back to shelling out from the Rake task to avoid pollution or if there's some other way to segregate things without messing up any other valid use cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR gathers tests by recursively looking for descendants of the TLDR class. If you have multiple Rake tasks that look in different places for tests, that's all well and good, but the first Rake task that runs (because it's all in the same process) will load all of its tests and the second Rake task will, of course, find them, because they're still defined.
Decoupling path from test definition is generally good but in this particular case it is not fantastic. Makes me wonder if we should go back to shelling out from the Rake task to avoid pollution or if there's some other way to segregate things without messing up any other valid use cases
This PR just pushes up a failing test.