Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(campaign): add event for campaign auction creation #841

Merged
merged 18 commits into from
Jun 20, 2022
Merged

feat(campaign): add event for campaign auction creation #841

merged 18 commits into from
Jun 20, 2022

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Jun 8, 2022 •
edited
Loading

Add the event for campaign auction creation using fundraising hooks.

The event associates a campaign ID with an auction ID.

@lumtis lumtis added the on hold For specific reasons, this issue is on hold label Jun 8, 2022
@lumtis lumtis linked an issue Jun 8, 2022 that may be closed by this pull request
Emit event for auction creation related to an existing campaign #823
Closed
@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #841 (6b2ed24) into develop (ee188db) will increase coverage by 0.02%.
The diff coverage is 18.69%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
+ Coverage    10.41%   10.43%   +0.02%     
===========================================
  Files          325      326       +1     
  Lines        76047    76261     +214     
===========================================
+ Hits          7917     7960      +43     
- Misses       67940    68111     +171     
  Partials       190      190
Impacted Files Coverage Δ
x/campaign/types/events.pb.go 0.55% <0.65%> (+<0.01%) ⬆️
x/campaign/keeper/campaign_auction_event_hooks.go 58.92% <58.92%> (ø)
x/campaign/keeper/campaign.go 100.00% <100.00%> (ø)
x/profile/keeper/coordinator.go 100.00% <100.00%> (ø)
x/campaign/simulation/store.go 83.10% <0.00%> (+2.02%) ⬆️

@lumtis lumtis removed the on hold For specific reasons, this issue is on hold label Jun 13, 2022
@lumtis lumtis marked this pull request as ready for review June 14, 2022 09:50
@lumtis lumtis mentioned this pull request Jun 14, 2022
Open
aljo242
aljo242 suggested changes Jun 14, 2022
View reviewed changes
Copy link

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the lint report as well

proto/campaign/events.proto Outdated Show resolved Hide resolved
x/campaign/keeper/campaign.go Show resolved Hide resolved
Pantani
Pantani reviewed Jun 15, 2022
View reviewed changes
go.mod Show resolved Hide resolved
lumtis and others added 2 commits June 17, 2022 15:10
@lumtis lumtis requested review from Pantani and aljo242 June 20, 2022 07:58
@aljo242 aljo242 merged commit b6a5d1d into develop Jun 20, 2022
@aljo242 aljo242 deleted the campaign-auction-event branch June 20, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@aljo242 aljo242 aljo242 approved these changes

@fadeev fadeev Awaiting requested review from fadeev

@ilgooz ilgooz Awaiting requested review from ilgooz

@ivanovpetr ivanovpetr Awaiting requested review from ivanovpetr

@giunatale giunatale Awaiting requested review from giunatale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emit event for auction creation related to an existing campaign
3 participants
@lumtis @Pantani @aljo242