Change LoadsViewsTest to match expected values #760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 5.8.5^ changed the filesystem slightly. This has caused errors in our tests for basically no reason. This quick fix simply fixes the values to a point where they should match correctly.
|
Wait for confirmation of this comment. |
|
I think it's best that we strip the newline if there's no path present. Please also don't submit draft prs. |
|
@driesvints Hi Dries thanks for your fast response. It seems you misplaced your comment, @ArlonAntonius is a member of the Laravel Tenancy team and this is the hyn/multi-tenant repository ;) |
|
@luceos ugh, sorry about that 🤦♂️ |
|
No need, thanks for your hard work and re-opening the issue! |
|
Closing this PR as all of this has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5.8.5^ changed the filesystem slightly. This has caused errors in our tests for basically no reason.
This quick fix simply fixes the values to a point where they should match correctly.