Add relaxed log method duration threshold #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
approved these changes
Feb 10, 2025
|
|
||
| // relaxed thresholds for known longer operations | ||
| RelaxedThresholds = DurationThresholds{ | ||
| Error: 4000, |
There was a problem hiding this comment.
Let's set the values like this
2000/1000/500/250
There was a problem hiding this comment.
I see rollup consumption take 3s pretty regularly in the nodes atm, might reduce after I refactor the block submission stuff but that's why I went so high for a the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
ERRORs in the logs that are definitely not errors, not even warnings in some functions that take longer - rollup creation/ consumption for example.
What changes were made as part of this PR
RelaxedThresholdparameter you can provide to theLogMethodDurationto set the values to longer timescales.PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks