Fix duplicate key error on host batch insertion #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-malene
reviewed
Feb 4, 2025
go/host/storage/storage.go
Outdated
| } | ||
| return fmt.Errorf("could not add batch to host. Cause: %w", err) | ||
| } | ||
|
|
||
| if err := dbtx.Write(); err != nil { | ||
| if errors.Is(err, errutil.ErrAlreadyExists) { |
There was a problem hiding this comment.
I think this has to check over the text. The error here will be returned directly from the db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Getting a lot of batch duplicate key errors on the UAT validators due to bad error handling
What changes were made as part of this PR
dbTx.Commit()as wellPR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks