Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main - Rollup block timing fix #2278

Merged
merged 5 commits into from
Jan 29, 2025
Merged

main - Rollup block timing fix #2278

merged 5 commits into from
Jan 29, 2025

Conversation

badgersrus
Copy link
Contributor

@badgersrus badgersrus commented Jan 29, 2025 •
edited
Loading

Why this change is needed

We are trying to calculate the blockhash using the same block number as the current block.

What changes were made as part of this PR

  • Poll the block number in publisher to wait for the next block
  • Do not allow block binding number that are equal to current block in mgmt contract

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

tudor-malene
tudor-malene approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@tudor-malene tudor-malene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@badgersrus badgersrus merged commit 42ef365 into main Jan 29, 2025
5 checks passed
@badgersrus badgersrus deleted the will/rollup-timing-fix branch January 29, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudor-malene tudor-malene tudor-malene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badgersrus @tudor-malene