-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed allowed input toggle #269
base: master
Are you sure you want to change the base?
Conversation
@Eonasdan Is there anything I can do to get this merged/released? |
pls, @Eonasdan merge this change |
Thank you for fixing this annoying bug @bobvandevijver @Eonasdan pls merge this change. Without it, the datetimepicker is useless because the calendar hides immediately after it was shown. |
This project seems to be unmaintained as the maintainer is unresponsive. I have some plans about developing it further, so I have forked both
They are also available through NPM: In these two forks (I worked on the For now, I have left the If you have some pending PR you would like to merge, I invite you to fork my forks instead and we can work @HaroldPutman already sent me a PR which got merged in tonix-tuft/tempusdominus -> tonix-tuft/tempusdominus#1. P.S.: I have also created a React version of Tempus Dominus Bootstrap, available here (I hope you enjoy it 😃): |
Hello guys, I have sent all the PRs we have already merged into my two forks (https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap) I wanna thank @HaroldPutman, @pablo-lp and @zondatw for their contribution. I think that now it makes sense for us to continue to work on this project in my two forks and from the But again, as @Eonasdan was and still is unresponsive, I think it would make sense to continue the development from the two forked repos https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap now using the As always, PRs for new features, bugfixes are welcome! Thank you. Stay tuned. |
@tonix-tuft did this get fixed via #360/#340? |
@Eonasdan I don't think so. I have tried in my fork and the picker is not shown when the input gets the focus. But I don't think that this a big problem, because as soon as the input gets the focus you can press the keyboard's arrows and the picker is shown with the new date you have just selected through the arrow you pressed. From a UX perspective, even on mobile devices where the user doesn't have a keyboard, I don't see it as problem too because on mobile devices you don't navigate with TAB and as soon as you press the input the datetimepicker is shown (because of the click event being triggered instead of focus). Anyway, it's up to you and the other guys. For me, this fix can coexist without any problems. |
Fixes #80 for me. Not sure if it is correct in all scenarios, but I did not find any issues so far.