This repository was archived by the owner on May 26, 2023. It is now read-only.
Add remote data encoder support. #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support for remote data encoders. This is a new API currently under review at temporalio/sdk-go#717. This PR should not be merged until the SDK PR is merged.
For this first iteration only basic auth is supported via https://user:[email protected], oauth for the remote encoder is not supported.
Why?
This allows the web UI to make use of a shared remote encoder rather than needing to run
tctl dc webcommand locally. In this deployment model developers don't need to use the tctl plugin system or have access to the encryption keys on their development machine.Checklist
How was this tested:
Tested on my integration branch of backgroud-checks which has a full encryption data converter setup for a sample Temporal application.
Any docs updates needed?
Yes, documentation will be needed to explain how to deploy such a system.